PM-1206 - reset payment status #59
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| UPDATE payment | ||
| SET payment_status = 'ON_HOLD' | ||
| WHERE winnings_id IN ( |
There was a problem hiding this comment.
medium
performance
The subquery in the WHERE clause could potentially lead to performance issues if the winnings table is large. Consider using an EXISTS clause instead of IN to improve performance by stopping at the first match.
| FROM winnings | ||
| LEFT JOIN trolley_recipient ON winnings.winner_id = trolley_recipient.user_id | ||
| LEFT JOIN trolley_recipient_payment_method ON trolley_recipient.id = trolley_recipient_payment_method.trolley_recipient_id | ||
| WHERE payment.payment_status = 'OWED' AND ( |
There was a problem hiding this comment.
high
correctness
Ensure that the payment table is correctly joined with the winnings table. The current query assumes that winnings_id in the payment table directly corresponds to winning_id in the winnings table, which might not be the case if there are any discrepancies or missing foreign key constraints.
| LEFT JOIN trolley_recipient ON winnings.winner_id = trolley_recipient.user_id | ||
| LEFT JOIN trolley_recipient_payment_method ON trolley_recipient.id = trolley_recipient_payment_method.trolley_recipient_id | ||
| WHERE payment.payment_status = 'OWED' AND ( | ||
| trolley_recipient.trolley_id IS NULL OR |
There was a problem hiding this comment.
Can we please remove this?
Sorry, had to mention this in AC, but realized we could have trolley_id records pre-created for members when we import offline data. So we want to target members without trolley_recipient_payment_method set.
There was a problem hiding this comment.
This is cleared in Slack.
| LEFT JOIN trolley_recipient ON winnings.winner_id = trolley_recipient.user_id | ||
| LEFT JOIN trolley_recipient_payment_method ON trolley_recipient.id = trolley_recipient_payment_method.trolley_recipient_id | ||
| WHERE payment.payment_status = 'OWED' AND ( | ||
| trolley_recipient.trolley_id IS NULL OR |
There was a problem hiding this comment.
This is cleared in Slack.
https://topcoder.atlassian.net/browse/PM-1206 - Reset payment status for Owed/Available payments